Add support for HCN v2 endpoint and add unit tests #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to HCN v2 endpoint API instead of HNS v1 endpoint API * Support parsing routes in GCS when we setup the network interfaces * [breaking] update gcs bridge LCOW network adapter type with new fields that better align with v2 endpoint * Add unit tests for new GCS side changes Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
helsaawy
reviewed
Jan 10, 2025
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
user/kabaldau/lcow_hns_v2_endpoint_and_v1
branch
from
5190038 to
262f05c
Compare
helsaawy
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change was to support adding custom routes on interfaces. However, the v1 endpoint implementation does not have this support. Therefore, we needed to move to the V2 implementation.