-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix! Removes singleton registries #1634
Open
rkodev
wants to merge
19
commits into
main
Choose a base branch
from
fix/remove-singletons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+601
−455
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e0147f1
Fix
rkodev f2cc947
Fix import
rkodev f1ec3b2
Fix build
rkodev fc016c2
Fix
rkodev 54a6d22
Fix build
rkodev 2db7500
monir refactor
rkodev 4eb7936
Save info
rkodev 8dd1703
fix test
rkodev 60407b7
Migrate static functions to instance methods
rkodev 948b249
Fix constructor
rkodev 8b17aa3
fix
rkodev 4c00e2c
Fix build
rkodev c7e0e5b
Test Build
rkodev 9c7d08f
Fix build
rkodev bbcbbfd
Remove singleton backingstore
rkodev cf5bf50
Fix import
rkodev a425e59
merge main
rkodev b015997
Fix linting
rkodev a1c4d05
revert package-lock
rkodev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 0 additions & 71 deletions
71
packages/abstractions/src/serialization/kiotaJsonSerializer.ts
This file was deleted.
Oops, something went wrong.
149 changes: 0 additions & 149 deletions
149
packages/abstractions/src/serialization/kiotaSerializer.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those should probably be instance methods now that we require an instance to be passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to revert to functions since they will require cyclic dependencies that are problematic