Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hostapd WpaEventHandler available to upper layers #305

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow the middleware layers to access the hostapd event handler/producer.

Technical Details

  • Add IHostapd::GetEventHandler exposing a shared_ptr<WpaEventHandler> associated with the instance.
  • Implement IHostapd::GetEventHandler in Hostapd.
  • Convert std::unique_ptr<WpaEventHandler> to std::shared_ptr in Hostapd.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Register a listener on the handler in the AccessPointControllerLinux implementation.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 2, 2024 17:28
@abeltrano abeltrano merged commit 1445207 into develop Jul 2, 2024
4 checks passed
@abeltrano abeltrano deleted the hapdifevents branch July 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant