Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factor WpaKeyManagement conversion helpers #309

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow validation of conversion stability for WpaKeyManagement enumeration values.

Technical Details

  • Refactor existing code into new function which converts a string(_view) to a single WpaKeyManagement enumeration value.
  • Use range views to split the input string for parsing into a sequence of WpaKeyManagement values.
  • Add test to validate conversion to/from WpaKeyManagement and std::string_view is stable.
  • Add string helper to convert an arbitrary type to a std::string_view, primarily for use in range adaptors.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 3, 2024 03:19
@abeltrano abeltrano merged commit 3a76185 into develop Jul 3, 2024
5 checks passed
@abeltrano abeltrano deleted the wpakeymgmtstrconversion branch July 3, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant