Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log AP manager events and WPA events to audit log #312

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

corbin-phipps
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

This PR adds additional logging to the audit log, specifically for events. This includes WPA events from Hostapd::OnWpaEvent and AP manager events from AccessPointManager::AddAccessPoint and AccessPointManager::RemoveAccessPoint.

Technical Details

  • Added additional AUDIT_LOG* lines for events.

Test Results

TBD

Reviewer Focus

Are there any other places where it would be useful to log stuff to the audit log?

Future Work

None.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

Base automatically changed from user/corbinphipps/log-state-changes to develop July 16, 2024 16:41
@corbin-phipps corbin-phipps marked this pull request as ready for review July 16, 2024 16:54
@corbin-phipps corbin-phipps requested a review from a team as a code owner July 16, 2024 16:54
@abeltrano abeltrano merged commit 06f3b66 into develop Jul 16, 2024
1 of 4 checks passed
@abeltrano abeltrano deleted the user/corbinphipps/log-events branch July 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants