Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AccessPointAttributes JSON serialization/deserialization support #328

Merged
merged 4 commits into from
Jul 27, 2024
Merged

Add AccessPointAttributes JSON serialization/deserialization support #328

merged 4 commits into from
Jul 27, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow AccessPointAttributes to be encoded as JSON.
  • Allow AccessPointAttributes to be instantiated with JSON input (std::string, std::ifstream (intended for file)).

Technical Details

  • Add nlohmann::json to/from parsers for AccessPointAttributes.
  • Add basic unit test.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Allow specifying JSON file on command-line for netremote-server.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 27, 2024 08:24
@abeltrano abeltrano merged commit ebc50e5 into develop Jul 27, 2024
5 checks passed
@abeltrano abeltrano deleted the jsonattrs branch July 27, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano