Added support for spaces in file names.

[abenbachir]

This PR solve issue #87

[johnkord]

This test itself might fail on non-Linux platforms and RPM platforms. That could have serious repercussions for several other projects that rely on this code!

You probably want to disable this new unit test for all non-Debian systems! Or just not run this test at all :)

[abenbachir]

@johnkord can you include more people in this PR.

[johnkord]

@abenbachir I don't know anyone that works on this project anymore! Sorry I can't be of more help. Maybe @BingyuLiu knows? :)

[BingyuLiu]

@abenbachir <mailto:Abderrahmane.Benbachir@microsoft.com> , I was already moved out from OMI. @john Kordich<mailto:johnkord@microsoft.com>, appreciated for your help here. Hi Jadmohan and Jumping, Could you please help Abderrahmane? Thanks, John Liu

…

________________________________ From: John Kordich <notifications@github.com> Sent: Thursday, March 14, 2019 1:46 PM To: Microsoft/pal Cc: John Liu; Mention Subject: Re: [Microsoft/pal] Added support for spaces in file names. (#89) @abenbachir<https://github.com/abenbachir> I don't know anyone that works on this project anymore! Sorry I can't be of more help. Maybe @BingyuLiu<https://github.com/BingyuLiu> knows? :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#89 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASmHYz3fTl_0wtTwtbCKYZny05R0CTH2ks5vWrU8gaJpZM4bynfu>.

[JumpingYang001]

microsoft/omi-devs

It is good to support this fixes,
but since it is script changes, so it might affect package generate and installation for all product rely on pal. and maybe affect many platforms. I am not very familiar with pal.

[BingyuLiu]

Adding Saroj From: Bingyu Liu <John_LBY@outlook.com> Sent: Friday, March 15, 2019 2:49 AM To: Microsoft/pal <pal@noreply.github.com>; Microsoft/pal <reply@reply.github.com>; Abderrahmane Benbachir <Abderrahmane.Benbachir@microsoft.com>; John Kordich <johnkord@microsoft.com>; Jagmohan Singh <Jagmohan.Singh@microsoft.com>; Jumping Yang (Wicresoft North America Ltd) <v-zhenpy@microsoft.com> Cc: Mention <mention@noreply.github.com> Subject: Re: [Microsoft/pal] Added support for spaces in file names. (#89) @abenbachir <mailto:Abderrahmane.Benbachir@microsoft.com> , I was already moved out from OMI. @john Kordich<mailto:johnkord@microsoft.com>, appreciated for your help here. Hi Jadmohan and Jumping, Could you please help Abderrahmane? Thanks, John Liu

…

________________________________ From: John Kordich <notifications@github.com<mailto:notifications@github.com>> Sent: Thursday, March 14, 2019 1:46 PM To: Microsoft/pal Cc: John Liu; Mention Subject: Re: [Microsoft/pal] Added support for spaces in file names. (#89) @abenbachir<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fabenbachir&data=02%7C01%7CJagmohan.Singh%40microsoft.com%7Cb1ef006a17ac48aa1d6f08d6a8c2b5dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636881951574079160&sdata=91mgbEAZSpjzyz2412v7KH9lxOlLcTf9KVO%2BwYHd%2Flc%3D&reserved=0> I don't know anyone that works on this project anymore! Sorry I can't be of more help. Maybe @BingyuLiu<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBingyuLiu&data=02%7C01%7CJagmohan.Singh%40microsoft.com%7Cb1ef006a17ac48aa1d6f08d6a8c2b5dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636881951574079160&sdata=tzVAyHaaIJIKd65JGWLaIRosh7sg8zKCxQHjL7jLabE%3D&reserved=0> knows? :) - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpal%2Fpull%2F89%23issuecomment-473055188&data=02%7C01%7CJagmohan.Singh%40microsoft.com%7Cb1ef006a17ac48aa1d6f08d6a8c2b5dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636881951574079160&sdata=Pm2A6hvQLUuingRAKXpyP2Ghm6iLcGk7iXuz57sFdrY%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASmHYz3fTl_0wtTwtbCKYZny05R0CTH2ks5vWrU8gaJpZM4bynfu&data=02%7C01%7CJagmohan.Singh%40microsoft.com%7Cb1ef006a17ac48aa1d6f08d6a8c2b5dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636881951574079160&sdata=FmwUaOD45MUwlmnKSWMV76HaKsB8UfbbFezmMsjTg4c%3D&reserved=0>.

[abenbachir]

There is already a unit test been added by @johnkord in this PR.
Can we run those unit tests in different platforms ?

We can introduce this fix as a feature that we can enable with a cmd line like "--support-path-spaces"

[JumpingYang001]

the unittest only test space case, but for us/omi/scx team, we don't care it now, we are more care it not block exist omi and scx installation. so our test points are different.
you need to make sure it can generate rpm and deb packages for omsagent (as they are same way we used for omi) and also can install successfully on below platforms, then we are good to test for omi that time (we have other tasks now):

•CentOS 6 and 7 (x86 and x64)
•Debian 8 (x86 and x64) and Debian 9 x64
•Oracle Linux 5, 6, and 7 (x86 and x64)
•Red Hat Enterprise Linux Server 5 and 6, and 7 (x86 and x64) ◦Note: Red Hat 7.1 or later also runs on the PPC platform

•SUSE Linux Enterprise Server 11, 12 (x86 and x64), 12 ppc and 15.
•Ubuntu 14.04 LTS, 16.04 LTS and 18.04 LTS (x86 and x64)

[abenbachir]

+@shkhisti

@JumpingYang001 I will test the RPM and DEB packages on centos and ubuntu respectively. But due to lack of resources I can't test it on all the existing distro flavors. Do you have such infrastructure for this kind of test ?