-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for detecting $VIRTUAL_ENV
#181
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request adds support for detecting and including the “VIRTUAL_ENV” environment variable path when listing global virtual environment directories.
- Introduces a new parameter (virtual_env_env_var) to the list_global_virtual_envs_paths function.
- Checks and appends the detected path for “VIRTUAL_ENV” if it exists.
- Calls the updated function in find.rs to pass environment.get_env_var("VIRTUAL_ENV").
Changes
File | Description |
---|---|
crates/pet-global-virtualenvs/src/lib.rs | Adds a new optional parameter to handle the “VIRTUAL_ENV” variable |
crates/pet/src/find.rs | Passes the “VIRTUAL_ENV” environment variable to the updated function |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
@pantheraleo-7 Looks like one of the tests is failing would it be possible for you to take a look? |
|
Let me have a look |
Unfortunately the problem is with pyenv in ubuntu CI container. I have a fix for this #192 |
Addresses #180
(this is me writing rust for the first time 😬)