Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metro-service): lazy-load node-fetch to avoid punycode warning #3496

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix(metro-service): lazy-load node-fetch to avoid punycode warning #3496

merged 2 commits into from
Jan 29, 2025

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 27, 2025

Description

Lazy-load node-fetch to avoid punycode warning

Test plan

cd packages/metro-service
yarn build --dependencies
yarn test

There should be no punycode deprecation warning.

@tido64 tido64 requested a review from Saadnajmi January 27, 2025 11:20
@github-actions github-actions bot added the feature: metro This is related to Metro label Jan 27, 2025
@tido64 tido64 force-pushed the tido/metro-service-punycode-warning branch from 9c87399 to e273f47 Compare January 27, 2025 12:14
@tido64 tido64 merged commit 66d9673 into main Jan 29, 2025
12 checks passed
@tido64 tido64 deleted the tido/metro-service-punycode-warning branch January 29, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo JasonVMo approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

Assignees
No one assigned
Labels
feature: metro This is related to Metro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tido64 @Saadnajmi @JasonVMo