Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cli): fix test failing on Node 22 #3498

Merged
merged 1 commit into from
Jan 27, 2025
Merged

test(cli): fix test failing on Node 22 #3498

merged 1 commit into from
Jan 27, 2025

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 27, 2025

Description

Fix a test failing on Node 22

Test plan

Switch to Node 22.13.1.

cd packages/cli
yarn build --dependencies
yarn test

@tido64 tido64 requested a review from Saadnajmi January 27, 2025 14:50
@github-actions github-actions bot added the feature: cli This is related to CLI label Jan 27, 2025
@tido64 tido64 merged commit 5a06f5c into main Jan 27, 2025
12 checks passed
@tido64 tido64 deleted the tido/cli/fix-test-on-node-22 branch January 27, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: cli This is related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi