-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/pabhoj/featurellm_fix_paste #18442
Dev/pabhoj/featurellm_fix_paste #18442
Conversation
…Azure OpenAI resource (microsoft#16285) ## Summary of the Pull Request Adds an AI chatbot to Windows Terminal. Currently we do not ship with our own LLM, the user needs to provide their own Azure OpenAI subscription to be able to use this feature. - A new settings page has been added where the user can input their Azure OpenAI endpoint and key - A new palette has been added to the dropdown, called Terminal Chat - From Terminal Chat, the user can make queries to the provided endpoint for assistance with shell commands - We let the endpoint know about the user's current shell so that (hopefully) the commands received are relevant to the user's context - Received commands can be clicked from within the palette to be input into the user's active shell - The system prompt, alongside Azure OpenAI's in-built safeguards, should prevent strange/inappropriate replies from the LLM Co-authored-by: Dustin L. Howett <dustin@howett.net>
Instead of splitting up the resource strings in the resource file (which will cause localization issues), we now use resource strings with placeholders. Unfortunately, we still need to split the string to bind to xaml correctly since only part of the string should be hyperlinked. We do this in the code-behind, with the help of a helper function `SplitResourceStringWithPlaceholders`. Reviewers should start by looking at that function. ## Validation Steps Performed Hyperlinked text shows up as expected
- [x] Remove the ESC handler that clears the query message - [x] Streamline error handling code - [x] Fix `this` and `&` in several lambdas - [x] Fix getting the [active commandline properly](microsoft#16285 (comment)) - [x] Use XAML color ramp resource names instead of hardcoded colors
## Summary of the Pull Request We now verify that the model the user provided has the jailbreak content filter applied to it ## Validation Steps Performed - Models that do not have the jailbreak content filter are not permitted - Jailbreak attempts are caught ## PR Checklist - [ ] Closes #xxx - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
We recently added a check for a jailbreak filter as part of LLM validation, put this behind a velocity flag for now so that it isn't a breaking change for our already small number of users. Refs microsoft#16564
# Conflicts: # src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Instead of manually parsing out code blocks from the response we receive, leverage the markdown to xaml parsing introduced in microsoft#17585 ## Validation Steps Performed Responses are parsed as expected.
# Conflicts: # src/cascadia/TerminalSettingsEditor/MainPage.xaml
# Conflicts: # .github/actions/spelling/allow/allow.txt # src/cascadia/TerminalSettingsModel/AllShortcutActions.h
Let's use what we already got!
…oft#18386) ## Summary of the Pull Request Keeps any text in the input box around if Terminal Chat is dismissed. The original behaviour was consistent with the way the command palette works but it does not quite make sense for the chat. ## Validation Steps Performed Input is not lost when the chat pane is closed ## PR Checklist - [x] Closes microsoft#18151 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (3)devpack These words are not needed and should be removedabcd ABCDEFGHIJ abcdefghijk ABCDEFGHIJKLMNOPQRS ABCDEFGHIJKLMNOPQRST ABCDEFGHIJKLMNOPQRSTUVWXY allocs appium Argb asan autocrlf backported bytebuffer cac CLE codenav codepath commandline COMMITID componentization constness dealloc deserializers DISPATCHNOTIFY DTest entrypoints EVENTID FINDUP fuzzer hlocal hstring IInput Interner keyscan Munged numlock offboarded pids positionals Productize pseudoterminal remoting renamer roadmap ruleset SELECTALL somefile Stringable tearoff TODOs touchpad TREX Unregistering USERDATA vectorize viewports wslTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:AdvencedJavaProgramming/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/12877464665/attempts/1'
Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
No description provided.