Skip to content

Commit

Permalink
update where isWindows is
Browse files Browse the repository at this point in the history
  • Loading branch information
anthonykim1 committed Dec 4, 2024
1 parent e2a94b5 commit 49d8e41
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
3 changes: 1 addition & 2 deletions src/client/common/configSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ import {
} from './types';
import { debounceSync } from './utils/decorators';
import { SystemVariables } from './variables/systemVariables';
import { getOSType, OSType } from './utils/platform';
import { isWindows } from './platform/platformService';
import { getOSType, OSType, isWindows } from './utils/platform';
import { untildify } from './helpers';

export class PythonSettings implements IPythonSettings {
Expand Down
6 changes: 1 addition & 5 deletions src/client/common/platform/platformService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { injectable } from 'inversify';
import * as os from 'os';
import { coerce, SemVer } from 'semver';
import { getSearchPathEnvVarNames } from '../utils/exec';
import { Architecture, getArchitecture, getOSType, OSType } from '../utils/platform';
import { Architecture, getArchitecture, getOSType, isWindows, OSType } from '../utils/platform';
import { parseSemVerSafe } from '../utils/version';
import { IPlatformService } from './types';

Expand Down Expand Up @@ -73,7 +73,3 @@ export class PlatformService implements IPlatformService {
return getArchitecture() === Architecture.x64;
}
}

export function isWindows(): boolean {
return getOSType() === OSType.Windows;
}
2 changes: 1 addition & 1 deletion src/client/common/terminal/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
} from './types';
import { traceVerbose } from '../../logging';
import { getConfiguration } from '../vscodeApis/workspaceApis';
import { isWindows } from '../platform/platformService';
import { isWindows } from '../utils/platform';

@injectable()
export class TerminalService implements ITerminalService, Disposable {
Expand Down
4 changes: 4 additions & 0 deletions src/client/common/utils/platform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,7 @@ export function getUserHomeDir(): string | undefined {
}
return getEnvironmentVariable('HOME') || getEnvironmentVariable('HOMEPATH');
}

export function isWindows(): boolean {
return getOSType() === OSType.Windows;
}
3 changes: 2 additions & 1 deletion src/test/common/terminals/service.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { IServiceContainer } from '../../../client/ioc/types';
import { ITerminalAutoActivation } from '../../../client/terminals/types';
import { createPythonInterpreter } from '../../utils/interpreters';
import * as workspaceApis from '../../../client/common/vscodeApis/workspaceApis';
import * as platform from '../../../client/common/utils/platform';

suite('Terminal Service', () => {
let service: TerminalService;
Expand Down Expand Up @@ -95,7 +96,7 @@ suite('Terminal Service', () => {
mockServiceContainer.setup((c) => c.get(ITerminalActivator)).returns(() => terminalActivator.object);
mockServiceContainer.setup((c) => c.get(ITerminalAutoActivation)).returns(() => terminalAutoActivator.object);
getConfigurationStub = sinon.stub(workspaceApis, 'getConfiguration');
isWindowsStub = sinon.stub(platformService.object, 'isWindows');
isWindowsStub = sinon.stub(platform, 'isWindows');
pythonConfig = TypeMoq.Mock.ofType<WorkspaceConfiguration>();
editorConfig = TypeMoq.Mock.ofType<WorkspaceConfiguration>();
getConfigurationStub.callsFake((section: string) => {
Expand Down

0 comments on commit 49d8e41

Please sign in to comment.