Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting rules for ruff #22741

Merged
merged 21 commits into from
Mar 12, 2024
Merged

Add linting rules for ruff #22741

merged 21 commits into from
Mar 12, 2024

Conversation

brettcannon
Copy link
Member

No description provided.

karrtikr
karrtikr previously approved these changes Jan 11, 2024
@vscodenpa vscodenpa added this to the December / January 2024 milestone Jan 11, 2024
@brettcannon brettcannon added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Jan 11, 2024
brettcannon and others added 2 commits January 23, 2024 14:48
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@brettcannon
Copy link
Member Author

Another option here is to go w/ the default ruleset and just specify the docstring rules.

@brettcannon
Copy link
Member Author

@eleanorjboyd any idea why these tests are failing when I didn't make any semantic changes or touch the .data directory?

@brettcannon brettcannon merged commit 7ea5584 into microsoft:main Mar 12, 2024
35 checks passed
@brettcannon brettcannon deleted the ruff-rules branch March 12, 2024 19:25
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request Mar 14, 2024
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants