Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Terminal REPL triggers #23641

Merged
merged 15 commits into from
Jun 21, 2024
Merged

Unify Terminal REPL triggers #23641

merged 15 commits into from
Jun 21, 2024

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Jun 19, 2024

Resolves: #22242

Attempting to keep instance of REPL. Did not end up using shell integration for this, but shell integration and exit code will come in handy when we have to keep track of 'opened' state of REPL instance for cases when user wants to enter 'exit()'

@anthonykim1 anthonykim1 added area-terminal area-repl bug Issue identified by VS Code Team member as probable bug labels Jun 19, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review June 21, 2024 20:42
@anthonykim1 anthonykim1 self-assigned this Jun 21, 2024
@anthonykim1 anthonykim1 added this to the June 2024 milestone Jun 21, 2024
@anthonykim1 anthonykim1 merged commit c879780 into microsoft:main Jun 21, 2024
40 checks passed
DonJayamanne pushed a commit that referenced this pull request Jun 24, 2024
Resolves: #22242

Attempting to keep instance of REPL. Did not end up using shell
integration for this, but shell integration and exit code will come in
handy when we have to keep track of 'opened' state of REPL instance for
cases when user wants to enter 'exit()'
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 28, 2024
Resolves: microsoft#22242

Attempting to keep instance of REPL. Did not end up using shell
integration for this, but shell integration and exit code will come in
handy when we have to keep track of 'opened' state of REPL instance for
cases when user wants to enter 'exit()'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have "Run Selection/Line in Python terminal" work with "Start REPL"
3 participants