forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement default problem matcher and task for running Python files. #23953
Closed
Closed
Changes from 5 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
974dd83
Show dummy task
anthonykim1 f8344df
why isnt the problem matcher getting picked up
anthonykim1 c1a66cc
comments
anthonykim1 fd594d9
still cant access problem matcher
anthonykim1 496e351
cannot access problem matcher when it works by itself when in task.json
anthonykim1 1bcb272
remove runTask activation event
anthonykim1 c38c0f0
make file for task problem matcher
anthonykim1 81be0a9
need to change from hard-coded file to current open Python
anthonykim1 26b7d80
Trigger Task => Real Task to set up to get current active .py file
anthonykim1 294e4e4
add TODO. Need to get executable and python file info
anthonykim1 c803307
many TODOs
anthonykim1 73302c8
no way to get terminalService
anthonykim1 d5a6809
TODO: figure out how to get terminalShellType without terminalService
anthonykim1 bb0b9b4
progress on getting terminalShellType
anthonykim1 4121701
matching binding found for serviceIdentifier ICodeExecutionService
anthonykim1 d1d3ad7
might have to implement terminalCodeExecution from scratch
anthonykim1 5150e7f
have to implement codeExecutionService without injection
anthonykim1 eddd5c6
need to test if it works after figuring out python vs.pylance error
anthonykim1 1641506
Fix telemetry not getting picked up for Terminal REPL (#23958)
anthonykim1 092f5f0
Fix execInREPL Enter to respect complete expression (#23973)
anthonykim1 7916213
Add GDPR comment for `repltype` (#23974)
cwebster-99 71794f5
Additional graceful handling for pixi (#23942)
anthonykim1 9e44466
Do not truncate whitespace for multi-line string (#23977)
anthonykim1 06ef77e
Handle poetry env manager from native locator (#23983)
DonJayamanne 5b86f99
Update to latest lsp for pull diagnostics (#23979)
rchiodo 1c89714
Bump importlib-metadata from 8.1.0 to 8.4.0 (#23980)
dependabot[bot] 1a68554
Bump elliptic from 6.5.4 to 6.5.7 (#23986)
dependabot[bot] fedbf81
Fix stop sending double telemetry for Terminal REPL (#23995)
anthonykim1 e2b2c21
Correctly track native REPL state (#23997)
anthonykim1 b0a11c9
Version updates for Python Extension Release 2024.14.0 (#24040)
karthiknadig 0539b1e
Update `main` to next pre-release version (#24043)
karthiknadig dce3d09
fix django manage.py path validation (#24019)
eleanorjboyd 0c0d371
Fix failing multiroot test (#24049)
rchiodo b2b53d3
Remove use of mocked output channel in virtual workspace (#24051)
karthiknadig 34d9253
switch to using temp file for test_ids (#24054)
eleanorjboyd 72ecad7
Download `pet` from azure pipeline build (#24052)
karthiknadig b12cf87
Better messaging for tests output in virtual or untrusted scenario (#…
karthiknadig ece255a
Stable extension builds using `pet` from Azure Feed (#24063)
karthiknadig c570547
Update engine version to match LSP client (#24065)
rchiodo 127da14
Revert "Do not truncate whitespace for multi-line string" (#24096)
anthonykim1 14bb14b
Switch over to executeCommand from sendText (#24078)
anthonykim1 878d60a
Add `uv.lock` to file associations (#23991)
edgarrmondragon 9bc0813
Enable proposed APIs for `codeActionAI` (#24108)
StellaHuang95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,12 +73,55 @@ | |
"workspaceContains:manage.py", | ||
"workspaceContains:app.py", | ||
"workspaceContains:.venv", | ||
"workspaceContains:.conda" | ||
"workspaceContains:.conda", | ||
"onCommand:workbench.action.tasks.runTask" | ||
], | ||
"main": "./out/client/extension", | ||
"browser": "./dist/extension.browser.js", | ||
"l10n": "./l10n", | ||
"contributes": { | ||
"taskDefinitions": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need task definitions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{ | ||
"type": "pythonTask", | ||
"required": ["task"], | ||
"properties": { | ||
"task": { | ||
"type": "string", | ||
"description": "The task to customize" | ||
}, | ||
"file": { | ||
"type": "string", | ||
"description": "The file that provides the task. Can be omitted." | ||
} | ||
} | ||
} | ||
], | ||
"problemMatchers": | ||
anthonykim1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[ | ||
{ | ||
"name": "pythonCustomMatcher", | ||
"owner": "python", | ||
"source": "python", | ||
"fileLocation": "autoDetect", | ||
"pattern": [ | ||
{ | ||
"regexp": "^.*File \\\"([^\\\"]|.*)\\\", line (\\d+).*", | ||
"file": 1, | ||
"line": 2, | ||
"severity": 4, | ||
"message": 5 | ||
}, | ||
{ | ||
"regexp": "^.*raise.*$" | ||
}, | ||
{ | ||
"regexp": "^\\s*(.*)\\s*$", | ||
"message": 1 | ||
} | ||
] | ||
} | ||
], | ||
|
||
"walkthroughs": [ | ||
{ | ||
"id": "pythonWelcome", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recommend doing this.