Skip to content

Commit

Permalink
fix: Use a proper desktop name in package.json (#231472)
Browse files Browse the repository at this point in the history
Fixes #154693

Initally, this part is required due to how Electron handles the prorotol
registeration as in #56727 (comment) ( I also explained in #154693 (comment) )

However since
986b553
that part is no longer used for protocol registeration on Linux, and
since Electron 18, Electron uses the desktop file name to set the
`app_id` in Wayland, and it was given the wrong one. This change fixes the
problem where running VS Code on Wayland would have the `app_id` of
`code-url-handler` which is unreasonable.
  • Loading branch information
ShadowRZ authored Oct 17, 2024
1 parent 20c108c commit 8addf83
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions build/gulpfile.vscode.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,8 @@ function packageTask(platform, arch, sourceFolderName, destinationFolderName, op
const name = product.nameShort;
const packageJsonUpdates = { name, version };

// for linux url handling
if (platform === 'linux') {
packageJsonUpdates.desktopName = `${product.applicationName}-url-handler.desktop`;
packageJsonUpdates.desktopName = `${product.applicationName}.desktop`;
}

let packageJsonContents;
Expand Down

0 comments on commit 8addf83

Please sign in to comment.