Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli commands to get configuration from FortiGate #225 #226

Merged
merged 21 commits into from
Nov 25, 2024
Merged

Add cli commands to get configuration from FortiGate #225 #226

merged 21 commits into from
Nov 25, 2024

Conversation

patrikspiess
Copy link
Member

closes #225

@patrikspiess
✏️ Typo
b41f099
@patrikspiess
✨ Add new CLI commands to get cmdb configuration from a FortiGate. Bu…
9fc4c71 
…siness Logic not yet implemented
@patrikspiess
✏️ Missing dot (.)
1dc54fc
@patrikspiess
✏️ No need to write ot capitalized
beb2b7a
@patrikspiess
👔 Add API endpoint for 'fgt get cmdb firewall address'. Tests not yet…
5a17a62 
… implemented.
@patrikspiess
👔 Add API endpoint for 'fgt get cmdb firewall addrgrp'. Tests not yet…
c50e3b2 
… implemented.
@patrikspiess
⚰️ Unused import
24b199c
@patrikspiess
✅ Fix test for cli fgt get cmdb firewall addrgrp
85fc74b
@patrikspiess
📝 Update WHATSNEW
53caadc
@patrikspiess
📝 Add comment
8271fb3
@patrikspiess
🏗️ Add API endpoints for fgt cmdb services and refactoring
56cd072
@patrikspiess
♻️ Refactor CLI command structure for fgt get cmd firewall commands
10066ff
@patrikspiess
⚰️ Remove unused print()
91fe251
@patrikspiess
♻️ Rename native api() method to api_get()
c5ef184
@patrikspiess
✅ Test save_txt_file()
f71e27c
@patrikspiess
✅ Test save_raw()
b1033af
@patrikspiess
✅ Test the new FortiGate get... methods
da3cf35
@patrikspiess
✅ Add test for tools.fgt.get.api_get()
3e7448b
@patrikspiess
📝 Update WHATSNEW
bae463e
@patrikspiess patrikspiess requested a review from lucmurer October 22, 2024 13:07
@patrikspiess patrikspiess changed the title Add cli commands to get configuration from FortiGAte #225 Add cli commands to get configuration from FortiGate #225 Oct 22, 2024
lucmurer
lucmurer requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@lucmurer lucmurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phuh, quite a pull request :-) Well done, I would still change some stuff.

fotoobo/cli/fgt/fgt.py Show resolved Hide resolved
fotoobo/cli/fgt/get/cmdb/cmdb.py Show resolved Hide resolved
fotoobo/cli/fgt/get/get.py Show resolved Hide resolved
fotoobo/cli/main.py Show resolved Hide resolved
fotoobo/tools/fgt/cmdb/firewall/address.py Outdated Show resolved Hide resolved
fotoobo/tools/fgt/cmdb/firewall/addrgrp.py Outdated Show resolved Hide resolved
fotoobo/tools/fgt/cmdb/firewall/service_custom.py Outdated Show resolved Hide resolved
fotoobo/tools/fgt/cmdb/firewall/service_group.py Outdated Show resolved Hide resolved
fotoobo/tools/fgt/get.py Outdated Show resolved Hide resolved
@lucmurer lucmurer merged commit 5707b39 into migros:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucmurer lucmurer lucmurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CLI commands to get configuration from FortiGate
2 participants
@patrikspiess @lucmurer