Adds the ability to define a getMixPanelKey method on the user class … #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use for the identifier
|
Unfortunately Travis is failing due to composer memory issues PHP Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar:///home/travis/.phpenv/versions/7.3.22/bin/composer/src/Composer/DependencyResolver/Solver.php on line 223 |
|
@Arkitecht thanks for this PR. I will review it this weekend. :) |
|
COMPOSER_MEMORY_LIMIT=-1 might help to run Travis |
|
Hey @mikebronner - wondering if you had a chance to review this PR. Please let me know if there is anything I can do to help get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to define a getMixPanelKey method on the user class to use for the identifier