Removes effectfulness from makeFloatArray

mikesol · May 4, 2022 · 3fb1a1b · 3fb1a1b
1 parent 5b10e35
commit 3fb1a1b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/examples/docs/AudioUnits/WaveShaper.purs b/examples/docs/AudioUnits/WaveShaper.purs
@@ -51,9 +51,8 @@ waveShaperEx ccb _ ev = px ~~
       n_samples = 44100
 
       deg = pi / 180.0
-  wicked <- makeFloatArray (makeDistortionCurve 400.0)
   run2_
-    [ waveShaper wicked [ loopBuf buf bangOn ] ]"""
+    [ waveShaper (makeFloatArray (makeDistortionCurve 400.0)) [ loopBuf buf bangOn ] ]"""
       )
   , waveShaper: nut
       ( audioWrapper ev ccb (\ctx -> decodeAudioDataFromUri ctx "https://freesound.org/data/previews/339/339822_5121236-lq.mp3")
@@ -73,8 +72,7 @@ waveShaperEx ccb _ ev = px ~~
                 n_samples = 44100
 
                 deg = pi / 180.0
-            wicked <- makeFloatArray (makeDistortionCurve 400.0)
             run2 ctx
-              [waveShaper wicked [loopBuf buf bangOn]]
+              [waveShaper (makeFloatArray (makeDistortionCurve 400.0)) [loopBuf buf bangOn]]
       )
   }
diff --git a/src/WAGS/Interpret.js b/src/WAGS/Interpret.js
@@ -1376,13 +1376,11 @@ var setOff_ = function (ptr) {
 ///////////
 // various and sundry... mostly sundry... //
 export function makeFloatArray(fa) {
-	return function () {
-		var r = new Float32Array(fa.length);
-		for (var i = 0; i < fa.length; i++) {
-			r[i] = fa[i];
-		}
-		return r;
-	};
+	var r = new Float32Array(fa.length);
+	for (var i = 0; i < fa.length; i++) {
+		r[i] = fa[i];
+	}
+	return r;
 }
 
 export function stopMediaRecorder(mediaRecorder) {

diff --git a/src/WAGS/Interpret.purs b/src/WAGS/Interpret.purs
@@ -132,7 +132,7 @@ foreign import makeAudioBuffer
   :: WebAPI.AudioContext -> AudioBuffer -> Effect WebAPI.BrowserAudioBuffer
 
 -- | Make a float 32 array. Useful when creating a waveshaper node.
-foreign import makeFloatArray :: Array Number -> Effect WebAPI.BrowserFloatArray
+foreign import makeFloatArray :: Array Number -> WebAPI.BrowserFloatArray
 
 -- | Make a new audio context.
 foreign import context_ :: Effect WebAPI.AudioContext