Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update policy to add new deployer role #6790

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

jhpyke
Copy link
Contributor

@jhpyke jhpyke commented Feb 7, 2025

Pull Request Objective

This piece of work is being tracked in
this
GitHub Issue.

This adds the new airflow deployment role to the allowed list of deployers for xhibit

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

@jhpyke jhpyke requested a review from a team as a code owner February 7, 2025 11:05
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jhpyke, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_static_analysis

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jhpyke, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_plan

@jhpyke jhpyke force-pushed the add-airflow-deployer-role branch from 5037d26 to a6ceef7 Compare February 7, 2025 13:27
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhpyke jhpyke merged commit 51aec43 into main Feb 7, 2025
13 checks passed
@jhpyke jhpyke deleted the add-airflow-deployer-role branch February 7, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants