Add human-readable responses for /plr #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ewan-Donovan
approved these changes
Jan 15, 2025
lalithanagarur
added a commit
that referenced
this pull request
Jan 15, 2025
* added api endpoints * feat(*): format as per klint recommendations (#4) * PLR Integration Tests (#5) * Added integration tests for the PLR resource * KTlint fixes * Combined mocks into single LRS mock file * Updated readme for /plr endpoing * Removed wildcard imports * BTD-383: Add human-readable responses for /plr (#7) * Added integration tests for the PLR resource * KTlint fixes * Combined mocks into single LRS mock file * Updated readme for /plr endpoing * Removed wildcard imports * Updated responses for /plr to be human-readable * Removed commented code * BTD-379: Cover all response codes for learner endpoint (#6) * working tests for all response types (except errors, that's a different ticket) * wiremock addition of new response type * lint + refactors * OpenAPI docs * Test Fixes * Klint * Cleanup * Cleanup * Fix/failing builds (#8) * feat(*): fix failing builds by using secrets * feat(*): format entire source code * fix(SSLContextProviderTest): remove SSLContextProviderTest * feat(ResponseType): remove ResponseType as it is replaced by LRSResponseType --------- Co-authored-by: lalithanagarur <lalitha.nagarur@digital.justice.gov.uk> Co-authored-by: AlexYoungmanMoJ <alexander.youngman@digital.justice.gov.uk> Co-authored-by: Ewan-Donovan <ewan.donovan@digital.justice.gov.uk>
Ewan-Donovan
added a commit
that referenced
this pull request
Jan 17, 2025
* added api endpoints * feat(*): format as per klint recommendations (#4) * PLR Integration Tests (#5) * Added integration tests for the PLR resource * KTlint fixes * Combined mocks into single LRS mock file * Updated readme for /plr endpoing * Removed wildcard imports * BTD-383: Add human-readable responses for /plr (#7) * Added integration tests for the PLR resource * KTlint fixes * Combined mocks into single LRS mock file * Updated readme for /plr endpoing * Removed wildcard imports * Updated responses for /plr to be human-readable * Removed commented code * work in progress * BTD-379: Cover all response codes for learner endpoint (#6) * working tests for all response types (except errors, that's a different ticket) * wiremock addition of new response type * lint + refactors * OpenAPI docs * Test Fixes * Klint * Cleanup * Cleanup * Fix/failing builds (#8) * feat(*): fix failing builds by using secrets * feat(*): format entire source code * fix(SSLContextProviderTest): remove SSLContextProviderTest * feat(ResponseType): remove ResponseType as it is replaced by LRSResponseType * Fixes to tests noticed after refactor * Implemented on the PLR endpoint * Dependency removed * Add unit tests for LRSService * Add unit test for error * Add unit test for error for plr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.