PI-2772: Fix null address and surface type code

ministryofjustice · Feb 3, 2025 · 4d56dc7 · 4d56dc7
1 parent 5606f19
commit 4d56dc7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...kotlin/uk/gov/justice/digital/hmpps/integrations/delius/personalDetails/entity/Address.kt b/...kotlin/uk/gov/justice/digital/hmpps/integrations/delius/personalDetails/entity/Address.kt
@@ -56,8 +56,9 @@ class PersonAddress(
     @Convert(converter = YesNoConverter::class)
     var typeVerified: Boolean? = false,
 
+    @Column(nullable = false)
     @Convert(converter = YesNoConverter::class)
-    var noFixedAbode: Boolean? = false,
+    var noFixedAbode: Boolean = false,
 
     @Column(name = "last_updated_datetime")
     @LastModifiedDate

diff --git a/...and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/PersonalDetailsService.kt b/...and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/PersonalDetailsService.kt
@@ -87,7 +87,7 @@ class PersonalDetailsService(
             mainAddress.postcode = postcode
             mainAddress.type = addressType
             mainAddress.typeVerified = request.verified
-            mainAddress.noFixedAbode = request.noFixedAddress
+            mainAddress.noFixedAbode = request.noFixedAddress ?: false
             mainAddress.startDate = startDate
             mainAddress.endDate = request.endDate
             mainAddress.notes = request.notes
@@ -108,7 +108,7 @@ class PersonalDetailsService(
                 startDate = startDate,
                 endDate = request.endDate,
                 typeVerified = request.verified,
-                noFixedAbode = request.noFixedAddress,
+                noFixedAbode = request.noFixedAddress ?: false,
                 notes = request.notes,
                 id = null
             )