MLPAB-2731: Add material and immaterial change confirmed events #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acsauk
force-pushed
the
MLPAB-2713-add-material-immaterial-change-events
branch
4 times, most recently
from
371d034 to
264cac3
Compare
acsauk
commented
Feb 5, 2025
Comment on lines
23
to
27
| "if": { | ||
| "properties": { | ||
| "actorType": { "const": "attorney" } | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is in preparation for tickets like this but happy to drop if we'd rather keep this targeted at donors and CPs for now.
There was a problem hiding this comment.
I feel like it might be simpler to always have actorUID, even if we don't really need it
hawx
reviewed
Feb 6, 2025
| "description": "The UID of the actor that made the change", | ||
| "pattern": "^([a-z0-9]{8}-)([a-z0-9]{4}-){3}([a-z0-9]{12})$" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Q for Sirius people: will marking this as a material change trigger some communication we could include the date of in here? Since we want to have "We contacted you on {{.Date}} with guidance about what to do next." displayed, it would be nice to have the sent date
acsauk
force-pushed
the
MLPAB-2713-add-material-immaterial-change-events
branch
3 times, most recently
from
a907fd2 to
f83e260
Compare
acsauk
force-pushed
the
MLPAB-2713-add-material-immaterial-change-events
branch
from
f83e260 to
2a5912f
Compare
hawx
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables MLPAB-2731 and MLPAB-2732.