Fix openbsd as client #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
reviewed
Jan 4, 2025
dinosaure
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
For me it's ok if it's fix the initial issue reported. As far as a finalizer exists near the Lwt.async, I'm ok with that. The diffi is a bit noisy but it's ok.
If we look into details, we probably just need Lwt.catch. The initial issue is probably related to the fact that add_client raises an exception. Due to the fact that we did not catch it before this PR, the exception is propagated on top and fails our unikernel.
But let's fix it and release it as soon as we can 👍
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #208 there is an issue with OpenBSD as sys-net. This PR fixes the issue with a minimal change to HEAD. I can squash the commits together (e.g. 1 for the modifications and 1 for the hashsum) to avoid multiple WIP commits, but as I referenced some in the issue, I keeped them so far.