Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect openjdks #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Detect openjdks #9

wants to merge 3 commits into from

Conversation

akuhtz
Copy link

@akuhtz akuhtz commented Jun 14, 2019

This PR allows to detect the following OpenJDKs installation from the Windows registry:

  • Amazon Coretto
  • AdoptOpenJDK
  • Liberica

@VirtualTim
Copy link

I assume this makes #7 redundant.

Anyway, this is nice, and hopefully will be merged soon. It seems like this issue affects heaps of users.
Personally I think falling back to %JAVA_HOME% would be better, but if this isn't the direction the project wants to go in this PR seems to also be good.

@teras
Copy link

teras commented Jun 28, 2019

Hello, is there any compiled version of this PR or any ideas if this would be embedded?
Thank you

@akuhtz
Copy link
Author

akuhtz commented Jul 1, 2019

@teras Which OS do you use for the build?

@VirtualTim
Copy link

I'm sure there's many people who would appreciate 32/64 bit, Windows 10 / Server 2016 / Server 2019 builds.

@teras
Copy link

teras commented Jul 1, 2019

EDIT

@akuhtz I am using Linux & OSX, mainly OSX.

@VirtualTim
Copy link

Just to give some feedback, I've set up our builds with this patch and everything seems to work as expected. Testing has been done with Java 8 and 11.

@chutch1122
Copy link

Is this going to be released any time soon?

@iyh
Copy link

iyh commented Mar 18, 2020

just respect JAVA_HOME environment variable please...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants