-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect openjdks #9
base: master
Are you sure you want to change the base?
Conversation
I assume this makes #7 redundant. Anyway, this is nice, and hopefully will be merged soon. It seems like this issue affects heaps of users. |
Hello, is there any compiled version of this PR or any ideas if this would be embedded? |
@teras Which OS do you use for the build? |
I'm sure there's many people who would appreciate 32/64 bit, Windows 10 / Server 2016 / Server 2019 builds. |
EDIT @akuhtz I am using Linux & OSX, mainly OSX. |
Just to give some feedback, I've set up our builds with this patch and everything seems to work as expected. Testing has been done with Java 8 and 11. |
Is this going to be released any time soon? |
just respect |
This PR allows to detect the following OpenJDKs installation from the Windows registry: