-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rtt-target
from vl53l1-reg
#3
remove rtt-target
from vl53l1-reg
#3
Conversation
this dependency is not actually used in the crate but it's present in the released version of the crate. this leads to additional unnecessary dependencies in the consumers of this crate.
just as a note: this crate is being pulled in through
and @mitchmindtree: since this dependency isn't used here and also isn't re-exported (= not part of the public API) it'd be great if this could then be released as a patch release ( |
Thanks @rursprung! Would you be interested in helping maintain this crate? If so I can add you as an author here and on crates.io? |
Also for future reference, this repo will auto-publish new versions of the crate provided that the version in the cargo toml hasn't yet been published, meaning PRs that bump the version only require pressing merge to publish. |
thank you, but no - i'm only using this sensor for one small project now and probably won't use it in the future (and might not have access to it then, either). but maybe @TomSievers might be interested since his driver crate is based on this one?
oh, that's rather unusual (and seems to go against semver since the publishing can't know which part of the version number should be bumped?). i'm generally using manual releases and have started using just realised: the auto-publishing feature doesn't bump any version number, so it'll fail if this hasn't been done in the commit(s) being merged, as is e.g. the case here. so that way multiple PRs can be merged until one of them bumps the version number, leading to a new release. |
That's how I ended up creating this crate :)
I'll likely just do it locally and push to master this time as it looks like there are some other warnings to address. |
this dependency is not actually used in the crate but it's present in the released version of the crate. this leads to additional unnecessary dependencies in the consumers of this crate.