-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a quote from the president with a picture #5366
Conversation
Thanks @annagav the 2nd version looks good to me. I think this is good to merge once it's been reviewed by an engineer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One accessibility comment.
cms/templates/cms/home_page.html
Outdated
@@ -224,6 +224,11 @@ <h3>Join Us at Our Free Online Events</h3> | |||
<blockquote class="quote-text">“MicroMasters Programs offer unprecedented access points to advanced degrees, as well as to accelerated professional growth in some of the world's most in-demand fields. Through these programs, learners worldwide can gain the experience of a masters-level course of study, but also the confidence of thriving in an MIT-caliber education.”</blockquote> | |||
<p class="quote-author">Eric Grimson, Vice President of Open Learning, MIT </p> | |||
</div> | |||
<div class="row quote"> | |||
<img class="person" src="{% static 'images/kornbluth.png' %}" alt=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add something like "Sally Kornbluth, MIT President" for the alt text.
What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/2664
Description (What does it do?)
Add a quote form the president with a picture.
Screenshots (if appropriate):