Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quote from the president with a picture #5366

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Feb 5, 2024

What are the relevant tickets?

Fix https://github.com/mitodl/hq/issues/2664

Description (What does it do?)

Add a quote form the president with a picture.

Screenshots (if appropriate):

Screenshot 2024-02-05 at 12 00 52 PM

@annagav annagav changed the title Ag/add presidents quote Add a quote form the president with a picture Feb 5, 2024
@collinpreston collinpreston self-requested a review February 5, 2024 18:25
@annagav
Copy link
Contributor Author

annagav commented Feb 5, 2024

Update:
Screenshot 2024-02-05 at 1 32 15 PM

@pdpinch
Copy link
Member

pdpinch commented Feb 5, 2024

Thanks @annagav the 2nd version looks good to me. I think this is good to merge once it's been reviewed by an engineer.

@annagav annagav changed the title Add a quote form the president with a picture Add a quote from the president with a picture Feb 5, 2024
Copy link
Contributor

@collinpreston collinpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One accessibility comment.

@@ -224,6 +224,11 @@ <h3>Join Us at Our Free Online Events</h3>
<blockquote class="quote-text">“MicroMasters Programs offer unprecedented access points to advanced degrees, as well as to accelerated professional growth in some of the world's most in-demand fields. Through these programs, learners worldwide can gain the experience of a masters-level course of study, but also the confidence of thriving in an MIT-caliber education.”</blockquote>
<p class="quote-author">Eric Grimson, Vice President of Open Learning, MIT </p>
</div>
<div class="row quote">
<img class="person" src="{% static 'images/kornbluth.png' %}" alt="">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add something like "Sally Kornbluth, MIT President" for the alt text.

@annagav annagav merged commit a6afb1f into master Feb 5, 2024
4 checks passed
@annagav annagav deleted the ag/add_presidents_quote branch February 5, 2024 19:51
@odlbot odlbot mentioned this pull request Feb 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants