Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect footer logo to the open learning #5374

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

asadali145
Copy link
Contributor

What are the relevant tickets?

None, Based on mitodl/micromasters-zendesk-theme#1 (comment)

Description (What does it do?)

Updates the Link for the Open Learning logo.

How can this be tested?

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just one small change.

@@ -3,7 +3,7 @@
<div class="container">
<div class="row">
<div class="col-md-8">
<a href="http://www.mit.edu" target="_blank" rel="noopener noreferrer">
<a href="https://openlearning.mit.edu" target="_blank" rel="noopener noreferrer">
<img src="{% static 'images/open_learning_logo.svg' %}" alt="MIT" width="150" height="38">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="{% static 'images/open_learning_logo.svg' %}" alt="MIT" width="150" height="38">
<img src="{% static 'images/open_learning_logo.svg' %}" alt="MIT Open Learning" width="150" height="38">

Copy link
Member

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking after this

@asadali145 asadali145 merged commit 4af613d into master Mar 26, 2024
4 checks passed
@odlbot odlbot mentioned this pull request Mar 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants