Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add program_type and fix micromasters program certificates #910

Merged
merged 1 commit into from
Nov 6, 2023
Merged

add program_type and fix micromasters program certificates #910

merged 1 commit into from
Nov 6, 2023

Conversation

rachellougee
Copy link
Contributor

@rachellougee rachellougee commented Nov 3, 2023 •
edited
Loading

What are the relevant tickets?

#883

I've also created #916 but it doesn't need to be handled in this PR

Description (What does it do?)

  • add program_type, program_is_dedp and program_is_micromasters to staging and intermediate for MITx Online
  • 11 program certificates for program-v1:MITx+DEDP+2T2023 should now in int__micromasters__program_certificates

How can this be tested?

dbt build +int__mitx__program_certificates

--11
SELECT count(*) FROM "ol_data_lake_production"."ol_warehouse_production_rlougee_intermediate"."int__micromasters__program_certificates" 
where mitxonline_program_id = 3

---7213
SELECT count(*) FROM "ol_data_lake_production"."ol_warehouse_production_rlougee_intermediate"."int__mitx__program_certificates" 

---7213
SELECT count(*) FROM "ol_data_lake_production"."ol_warehouse_production_rlougee_intermediate"."int__micromasters__program_certificates"

@rachellougee rachellougee linked an issue Nov 3, 2023 that may be closed by this pull request
int__micromasters__program_certificates doesn't include the new DEDP program under older requirement #883
Closed
@rachellougee rachellougee force-pushed the 883-int__micromasters__program_certificates-doesnt-include-the-new-dedp-program-under-older-requirement branch from c36f6f2 to 2068ad2 Compare November 6, 2023 16:51
@rachellougee rachellougee requested a review from abeglova November 6, 2023 17:16
@abeglova abeglova self-assigned this Nov 6, 2023
abeglova
abeglova approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachellougee rachellougee merged commit d2c8dc9 into main Nov 6, 2023
@rachellougee rachellougee deleted the 883-int__micromasters__program_certificates-doesnt-include-the-new-dedp-program-under-older-requirement branch November 6, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeglova abeglova abeglova approved these changes

Assignees

@abeglova abeglova

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

int__micromasters__program_certificates doesn't include the new DEDP program under older requirement
2 participants
@rachellougee @abeglova