Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and docs #13

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update tests and docs #13

merged 3 commits into from
Nov 11, 2024

Conversation

endoze
Copy link
Contributor

@endoze endoze commented Nov 9, 2024

In order to simplify documentation, this PR moves most of the
documentation directly into the README.md. Additionally, to avoid
duplication, this PR pulls in the README.md into the crate docs.
This allows one source of truth for documentation and a common
experience between viewing the crate on github, crates.io, and docs.rs.

Additionally, this PR removes an unused/deprecated crate (block_modes)
and fixes minor spelling errors in the tests.

In order to ensure test descriptions match what they are testing, this
commit replaces occurences of hamc with hmac as this is the proper name
of the message integrity algorithm.
In order to remove a deprecated and unused crate from the dependencies,
this commit removes block_modes. This crate was deprecated in favor of
the crate collection under [RustCrypto](https://github.com/RustCrypto/block-modes).
It's also currently not being used in the source anywhere.
In order to simplify documentation, this commit moves most of the
documentation directly into the README.md. Additionally, to avoid
duplication, this commit pulls in the README.md into the crate docs.
This allows one source of truth for documentation and a common
experience between viewing the crate on github, crates.io, and docs.rs.
@endoze endoze force-pushed the update-tests-and-docs branch from 04d787d to 5f7b3b8 Compare November 9, 2024 18:29
@mjc-gh mjc-gh merged commit 4f2eaff into mjc-gh:main Nov 11, 2024
3 checks passed
@mjc-gh
Copy link
Owner

mjc-gh commented Nov 11, 2024

Thanks you for this contribution!

@endoze endoze deleted the update-tests-and-docs branch November 11, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants