Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rainbow font #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add rainbow font #1

wants to merge 3 commits into from

Conversation

haavarop
Copy link
Member

@haavarop haavarop commented Jul 14, 2019

  • Add rainbow css styling with class-name rainbow
  • Add test file in same directory
  • Rainbow font is of the Arial font-family
  • The text has a shadow that is not quite the same as the original, but it is added for respect.

@haavarop haavarop requested a review from afriestad July 14, 2019 18:59

.shadow {
position: absolute;
left: 13px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pixel positioning will only fit properly on h2.rainbow, won't it? What if the class is set on a h1, h5 or p? Do we want to support arbitrary text size?

Copy link
Member Author

@haavarop haavarop Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly no! I have tested it with the different headers and paragraph tags and they seem to work. Since both the text and the "shadow" are in the same container the absolute -tag positions them properly to each other. As long as they both have the same tag that is.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The left seems to not work correctly on small font sizes, e.g. for a p it looks like this:

image

Perhaps we could set it to a fraction of the font size, instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang it. Then we need to do that.
I am not happy with the shadows in their current state. I kinda want to remove them outright

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would not be true to the original form, but it might be acceptable to do so now and add shadows later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants