-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rainbow font #1
base: master
Are you sure you want to change the base?
Conversation
|
||
.shadow { | ||
position: absolute; | ||
left: 13px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pixel positioning will only fit properly on h2.rainbow, won't it? What if the class is set on a h1, h5 or p? Do we want to support arbitrary text size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly no! I have tested it with the different headers and paragraph tags and they seem to work. Since both the text and the "shadow" are in the same container the absolute
-tag positions them properly to each other. As long as they both have the same tag that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang it. Then we need to do that.
I am not happy with the shadows in their current state. I kinda want to remove them outright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would not be true to the original form, but it might be acceptable to do so now and add shadows later.
rainbow