Fix GPU sort for large arrays #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barronalex
reviewed
Jul 24, 2024
| @@ -1840,6 +1840,15 @@ def test_sort(self): | |||
| self.assertTrue(np.array_equal(c_np, c_mx)) | |||
| self.assertEqual(b_mx.dtype, c_mx.dtype) | |||
|
|
|||
| # Test very large array | |||
| if mx.default_device() == mx.gpu: | |||
There was a problem hiding this comment.
Is it just too slow for CI on CPU?
barronalex
approved these changes
Jul 24, 2024
barronalex
reviewed
Jul 24, 2024
| @@ -1785,15 +1785,6 @@ array sort(const array& a, int axis, StreamOrDevice s /* = {} */) { | |||
| throw std::invalid_argument(msg.str()); | |||
| } | |||
|
|
|||
| // TODO: Fix GPU kernel | |||
There was a problem hiding this comment.
Is worth a warning here for sorts greater than maxint?
There was a problem hiding this comment.
array::shape is made of ints, so each of those will be <= INT_MAX
There was a problem hiding this comment.
Ah good point -- nice!
|
Thanks for the quick fix 🚀 |
|
I noticed that the Lines 1845 to 1847 in e9e5385 |
|
That looks like an oversight. Will fix for the next release. |
|
(Fixed in #1289 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1254 - GPU sort should now support arbitrarily large arrays (as long as their shape is contained in
int)Added relevant test
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes