Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not join threads on process exit #1738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not join threads on process exit #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions mlx/scheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ namespace scheduler {

/** A singleton scheduler to manage devices, streams, and task execution. */
Scheduler& scheduler() {
static Scheduler scheduler;
return scheduler;
// By creating the |scheduler| on heap, the destructor of Scheduler will not
// be called on exit and stream threads will not be joined. This is because
// the threads may already be destroyed by OS (especially on Windows) during
// process exit.
static Scheduler* scheduler = new Scheduler;
return *scheduler;
}

} // namespace scheduler
Expand Down