-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move POST /mlflow/model-versions/create endpoint. #129
Draft
dsuhinin
wants to merge
17
commits into
mlflow:main
Choose a base branch
from
dsuhinin:dsuhinin/move-create-model-version-endpoint-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Move POST /mlflow/model-versions/create endpoint. #129
dsuhinin
wants to merge
17
commits into
mlflow:main
from
dsuhinin:dsuhinin/move-create-model-version-endpoint-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Software Developer <suhinin.dmitriy@gmail.com>
This reverts commit 6b5c7a3.
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem to fully finish current PR. Problem related to original
mlflow
implementation which works under the good and how tests organized. The main problem, that themlflow
Python tests expect to haveversion
property in 2 different types:string
type inRESTFul
tests andint
type instore
tests.Current
go
implementation is using the single entry point for bothRESTful
andstore
parts and using theproto
objects to receive and return information. As a result some of Python tests just failing, becauseversion
property is always instring
format which is not fully correct.The possible and maybe the most correct solution is to modify original
mflow
logic to haveversion
property in the same type for bothRESTful
andstore
parts. It could be a problematic, because it needs to change aproto
contract or internal logic.