Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move POST /mlflow/model-versions/create endpoint. #129

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Feb 6, 2025

There is a problem to fully finish current PR. Problem related to original mlflow implementation which works under the good and how tests organized. The main problem, that the mlflow Python tests expect to have version property in 2 different types: string type in RESTFul tests and int type in store tests.

Current go implementation is using the single entry point for both RESTful and store parts and using the proto objects to receive and return information. As a result some of Python tests just failing, because version property is always in string format which is not fully correct.

The possible and maybe the most correct solution is to modify original mflow logic to have version property in the same type for both RESTful and store parts. It could be a problematic, because it needs to change a proto contract or internal logic.

@dsuhinin dsuhinin changed the title Move Move POST /mlflow/model-versions/create endpoint. Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant