Skip to content

Commit

Permalink
Merge pull request #137 from mlibrary/LIBSEARCH-1032-test-an-integrat…
Browse files Browse the repository at this point in the history
…ion-of-book-covers-from-syndetic-solutions-in-the-shelf-carousel

[LIBSEARCH-1032] Test an integration of book covers from Syndetic Solutions in the shelf carousel
  • Loading branch information
erinesullivan authored Mar 3, 2025
2 parents 318f5ec + d29da55 commit b1d77b6
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
15 changes: 15 additions & 0 deletions lib/models/carousel_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ def call_number
@browse_doc["callnumber"]&.strip
end

def isbn
@catalog_doc["isbn"]&.first&.strip
end

def issn
@catalog_doc["issn"]&.first&.strip
end

def oclc
@catalog_doc["oclc"]&.first&.strip
end

def mms_id
@browse_doc["bib_id"]
end
Expand All @@ -52,6 +64,9 @@ def to_h
author: author,
date: date,
call_number: call_number,
isbn: isbn,
issn: issn,
oclc: oclc,
url: url
}
end
Expand Down
14 changes: 14 additions & 0 deletions spec/models/carousel_list_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def body(file_name)
describe CarouselList::CarouselItem do
before(:each) do
@catalog_doc = JSON.parse(fixture("biblio_results.json"))["response"]["docs"].first
@catalog_doc["isbn"] = ["1-5011-8342-7"]
@catalog_doc["issn"] = ["1096-9942"]
@browse_doc = JSON.parse(fixture("callnumbers_results.json"))["response"]["docs"].first
end
subject do
Expand All @@ -34,6 +36,15 @@ def body(file_name)
it "has a call_number" do
expect(subject.call_number).to eq("Z 253 .U6 1963")
end
it "has an isbn" do
expect(subject.isbn).to eq("1-5011-8342-7")
end
it "has an issn" do
expect(subject.issn).to eq("1096-9942")
end
it "has an oclc" do
expect(subject.oclc).to eq("2497305")
end
it "has an mms_id" do
expect(subject.mms_id).to eq("990011613060106381")
end
Expand All @@ -49,6 +60,9 @@ def body(file_name)
author: "United States. Government Printing Office",
call_number: "Z 253 .U6 1963",
date: "1950",
isbn: "1-5011-8342-7",
issn: "1096-9942",
oclc: "2497305",
title: "Theory and practice of composition.",
url: "#{S.search_url}/catalog/record/990011613060106381"

Expand Down

0 comments on commit b1d77b6

Please sign in to comment.