Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libsearch 944 language codes in 041 #95

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Libsearch 944 language codes in 041 #95

merged 2 commits into from
Oct 7, 2024

Conversation

niquerio
Copy link
Collaborator

@niquerio niquerio commented Oct 2, 2024 •
edited
Loading

This PR address LIBSEARCH-944

  • Tidies the specs by moving the get_record function into spec_helper.
  • For the language field, this skips non control fields with a subfield 2 value. In this case the only one is 041.

The code for handling languages comes directly from the marc21_semantics macros.

@niquerio
move get_record to spec_helper
c86ecb9
@niquerio
fix: language with subfield 2 skipped
ad883a9 
adds the marc_languages macro code from https://github.com/traject/traject/blob/main/lib/traject/macros/marc21_semantics.rb
into the languages field. Adds a clause to skip fields that have a
subfield 2.
@niquerio niquerio marked this pull request as ready for review October 2, 2024 17:53
@niquerio niquerio requested a review from billdueber October 2, 2024 17:53
@niquerio niquerio merged commit b0dcaee into main Oct 7, 2024
1 check passed
@niquerio niquerio deleted the LIBSEARCH-944-language-codes-in-041 branch December 16, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billdueber billdueber Awaiting requested review from billdueber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niquerio