Throw SFTP::Error when Bash process started by Shell fails
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niquerio
approved these changes
Mar 19, 2024
|
I think it'd be helpful if the readme was updated to discuss the change. |
ssciolla
commented
Mar 19, 2024
Comment on lines
+89
to
+90
| If a failure occurs when an underlying `sftp` command is run, an `SFTP::Error` will be raised. | ||
|
|
There was a problem hiding this comment.
@niquerio, do you think this is sufficient?
niquerio
approved these changes
Mar 19, 2024
Comment on lines
+89
to
+90
| If a failure occurs when an underlying `sftp` command is run, an `SFTP::Error` will be raised. | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to raise an error if the Bash process started by
Shellfails. This seems to me improved behavior over silently failing and continuing, though I'm happy to listen to other views.