Skip to content

Commit

Permalink
Updates get_this.yml to include asia backlog
Browse files Browse the repository at this point in the history
* removes international_studies specific method from decorator
  • Loading branch information
niquerio committed Jun 7, 2024
1 parent 986c50a commit 16da473
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 18 deletions.
4 changes: 2 additions & 2 deletions config/get_this.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
- not_building_use_only?
- not_game?

# Pickup (5 of 6) WORK_ORDER_DEPARTMENT AcqTechServices for ISEEES
# Pickup (5 of 6) WORK_ORDER_DEPARTMENT AcqTechServices for ISEEES and ASIA transit
- label: Request for pick up at a library
summary: We'll find the item and send it to the library of your choice for pick up in 1-5 days.
description:
Expand All @@ -206,7 +206,7 @@
grants:
holding:
- ann_arbor?
- in_international_studies_acquisitions_technical_services?
- in_slower_pickup?
- can_request?

# Pickup (6 of 6)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class PhysicalItemDecorator < SimpleDelegator
ETAS_START = "Full text available,"

extend Forwardable
def_delegators :@work_order_option, :in_labeling?, :in_international_studies_acquisitions_technical_services?
def_delegators :@work_order_option, :in_labeling?

attr_reader :hathi_holding
def initialize(item, hathi_holdings = [], work_order_option = Spectrum::Entities::GetThisWorkOrderOption.for(item))
Expand Down Expand Up @@ -179,10 +179,6 @@ def in_asia_transit?
@item.library == "HATCH" && @item.location == "ASIA" && @item.process_type == "TRANSIT"
end

def not_in_international_studies_acquisitions_technical_services?
!in_international_studies_acquisitions_technical_services?
end

def building_use_only?
@item.fulfillment_unit == "Limited" || @item.item_policy == "08" # 08 for Special Collections is also Reading Room Only
end
Expand Down
11 changes: 0 additions & 11 deletions spec/spectrum/decorators/physical_item_decorator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,6 @@
context "work order methods" do
# mrio: both of these would be booleans, but having them return strings shows
# that the correct path through the code is being used.
it "responds to #in_international_studies_acquisitions_technical_services?" do
expect(subject.in_international_studies_acquisitions_technical_services?).to eq("in_international_studies_acquisitions_technical_services")
end
it "responds to #not_in_international_studies_acquisitions_technical_services?" do
expect(subject.not_in_international_studies_acquisitions_technical_services?).to eq(false)
end
it "responds to #in_labeling?" do
expect(subject.in_labeling?).to eq("in_labeling")
end
Expand Down Expand Up @@ -54,11 +48,6 @@
expect(subject.in_slower_pickup?).to eq(false)
end
end
it "response to #not_in_slower_pickup?" do
allow(@input[:solr_item]).to receive(:library).and_return("SHAP")
allow(@input[:solr_item]).to receive(:location).and_return("MAIN")
expect(subject.not_in_slower_pickup?).to eq(true)
end
context "in_asia_transit?" do
it "is true when in Asia library and process type transit" do
allow(@input[:solr_item]).to receive(:library).and_return("HATCH")
Expand Down

0 comments on commit 16da473

Please sign in to comment.