Merge pull request #91 from mlibrary/loans-api-optional

fix: handles not being able to contact Alma
mlibrary · Jul 6, 2022 · d6552f1 · d6552f1
2 parents 48bfb4b + 396b731
commit d6552f1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/local-gems/spectrum-json/lib/spectrum/entities/alma_holdings.rb b/local-gems/spectrum-json/lib/spectrum/entities/alma_holdings.rb
@@ -8,11 +8,13 @@ def initialize(alma:, solr:)
   end
   def self.for(bib_record:, client: AlmaRestClient.client)
     if bib_record.physical_holdings?
-      response = client.get_all(url: "/bibs/#{bib_record.mms_id}/loans", record_key: "item_loan")
-      if response.code == 200
+      begin
+        response = client.get_all(url: "/bibs/#{bib_record.mms_id}/loans", record_key: "item_loan")
+        raise ::StandardError.new("problem with contacting alma") if response.code != 200
         Spectrum::Entities::AlmaHoldings.new(alma: response.parsed_response, solr: bib_record)
-      else
-        #TBD ERROR
+      rescue => e
+        Logger.new($stdout).error "Cant'contact Alma: #{e}"
+        Spectrum::Entities::AlmaHoldings.new(alma: { "item_loan" => [] }, solr: bib_record)
       end
     else
       Spectrum::Entities::AlmaHoldings::Empty.new