Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This introduces mypy as a type checker and fixes some issues/inconsistencies that were found while implementing it.
This is only a start of type checking as many functions do not have type annotations yet, but this could help us to
extend the type checking more and more.
< Please also include relevant motivation and context. >
This was originally motivated by #106 where type-checking could have helped to identify the issue earlier. However, in that particular case it does not help because of other un-typed functions/missing type information of external packages.
< List any dependencies that are required for this change. >
Issue Link
< Link to the relevant issue or task. > (e.g.
closes #00
orsolves #00
)Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee