Update test vectors to have key packages with eternal lifetime #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelrobert
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks for taking care of it @mulmarta! I can confirm the vectors pass with OpenMLS. I noticed that passive-client-random.json is about 10x bigger than before though. Since it's a lot of data and it makes the test quite slow, could please make a smaller version?
I didn't notice, it used to have only cipher suite 1. I removed all cipher suites other than 1 (since the cipher suite doesn't matter for this test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #181
New test vectors with eternal lifetime come from awslabs/mls-rs/pull/113. I verified that OpenMLS's tests work with the new vectors.