[fix]

* add some checks if the form does not match configured type
* some checks to prevent a few crashes
* added updated sample images

src/equip/item/potion.cpp

@@ -5,14 +5,13 @@ namespace item {
     void potion::consume_potion(handle::slot_setting*& a_slot, RE::PlayerCharacter*& a_player) {
         logger::trace("try to consume {}"sv, a_slot->form->GetName());
 
+
         RE::TESBoundObject* obj = nullptr;
-        RE::InventoryEntryData inv_data;
         uint32_t left;
         for (auto potential_items = inventory::get_inventory_magic_items(a_player);
              const auto& [item, invData] : potential_items) {
             if (invData.second->object->formID == a_slot->form->formID) {
                 obj = item;
-                inv_data = *invData.second;
                 left = invData.first;
                 break;
             }
@@ -25,6 +24,11 @@ namespace item {
             return;
         }
 
+        if (!obj->Is(RE::FormType::AlchemyItem)) {
+            logger::warn("object {} is not an alchemy item. return."sv, obj->GetName());
+            return;
+        }
+
         logger::trace("calling drink/eat potion/food {}, count left {}"sv, obj->GetName(), left);
 
         const auto equip_manager = RE::ActorEquipManager::GetSingleton();

src/equip/item/weapon.cpp

@@ -14,8 +14,16 @@ namespace item {
         RE::ExtraDataList* extra = nullptr;
         std::map<RE::TESBoundObject*, std::pair<int, std::unique_ptr<RE::InventoryEntryData>>> potential_items;
         if (a_weapon) {
+            if (!a_form->Is(RE::FormType::Weapon)) {
+                logger::warn("object {} is not a weapon. return."sv, a_form->GetName());
+                return;
+            }
             potential_items = inventory::get_inventory_weapon_items(a_player);
         } else {
+            if (!a_form->Is(RE::FormType::Armor)) {
+                logger::warn("object {} is not an armor. return."sv, a_form->GetName());
+                return;
+            }
             potential_items = inventory::get_inventory_armor_items(a_player);
         }
 

src/equip/magic/power.cpp

@@ -33,6 +33,10 @@ namespace magic {
     void power::equip_or_cast_power(RE::TESForm* a_form, action_type a_action, RE::PlayerCharacter*& a_player) {
         logger::trace("try to work power {}, action {}"sv, a_form->GetName(), static_cast<uint32_t>(a_action));
 
+        if (!a_form->Is(RE::FormType::Spell)) {
+            logger::warn("object {} is not a spell. return."sv, a_form->GetName());
+            return;
+        }
 
         if (const auto selected_power = a_player->GetActorRuntimeData().selectedPower;
             selected_power != nullptr && a_action != handle::slot_setting::acton_type::instant) {

src/equip/magic/shout.cpp

@@ -19,6 +19,11 @@ namespace magic {
     void shout::equip_shout(RE::TESForm* a_form, RE::PlayerCharacter*& a_player) {
         logger::trace("try to equip shout {}"sv, a_form->GetName());
 
+        if (!a_form->Is(RE::FormType::Shout)) {
+            logger::warn("object {} is not a shout. return."sv, a_form->GetName());
+            return;
+        }
+
         if (const auto selected_power = a_player->GetActorRuntimeData().selectedPower;
             selected_power != nullptr) {
             logger::trace("current selected power is {}, is shout {}, is spell {}"sv,

src/equip/magic/spell.cpp

@@ -49,6 +49,12 @@ namespace magic {
             a_form->GetName(),
             static_cast<uint32_t>(a_action),
             left);
+
+        if (!a_form->Is(RE::FormType::Spell)) {
+            logger::warn("object {} is not a spell. return."sv, a_form->GetName());
+            return;
+        }
+
         const auto spell = a_form->As<RE::SpellItem>();
 
         //spell->avEffectSetting->data.dualCastScale

src/handle/page_handle.cpp

@@ -212,6 +212,9 @@ namespace handle {
     }
 
     void page_handle::get_icon_for_weapon_type(RE::TESForm*& a_form, ui::icon_image_type& a_icon) {
+        if (!a_form->IsWeapon()) {
+            return;
+        }
         switch (const auto weapon = a_form->As<RE::TESObjectWEAP>(); weapon->GetWeaponType()) {
             case RE::WEAPON_TYPE::kHandToHandMelee:
                 break;
@@ -246,6 +249,9 @@ namespace handle {
     }
 
     void page_handle::get_icon_for_spell(RE::TESForm*& a_form, ui::icon_image_type& a_icon) {
+        if (!a_form->Is(RE::FormType::Spell)) {
+            return;
+        }
         const auto spell = a_form->As<RE::SpellItem>();
         const auto effect = spell->GetCostliestEffectItem()->baseEffect;
         auto actor_value = effect->GetMagickSkill();
@@ -284,6 +290,9 @@ namespace handle {
     }
 
     void page_handle::get_icon_for_consumable(RE::TESForm*& a_form, ui::icon_image_type& a_icon) {
+        if (!a_form->Is(RE::FormType::AlchemyItem)) {
+            return;
+        }
         const auto alchemy_potion = a_form->As<RE::AlchemyItem>();
 
         if (alchemy_potion->IsFood()) {
@@ -330,7 +339,10 @@ namespace handle {
     }
 
     void page_handle::get_icon_for_item(RE::TESForm*& a_form, ui::icon_image_type& a_icon) {
-        switch (const auto weapon = a_form->As<RE::TESObjectARMO>(); weapon->GetArmorType()) {
+        if (!a_form->IsArmor()) {
+            return;
+        }
+        switch (const auto armor = a_form->As<RE::TESObjectARMO>(); armor->GetArmorType()) {
             case RE::BIPED_MODEL::ArmorType::kLightArmor:
                 a_icon = ui::icon_image_type::armor_light;
                 break;

src/papyrus/papyrus.cpp

@@ -30,7 +30,7 @@ namespace papyrus {
         logger::info("Got refresh for id {}, both hands {}, instant {}"sv, a_id, a_both, a_instant_cast);
         std::vector<RE::BSFixedString> empty_string_vec = { util::empty_enum_string };
         const auto display_string_list = new std::vector<RE::BSFixedString>;
-        //clear_list();
+        clear_list();
         //let the list be valid until it is refreshed again, might be an issue with magic and weapon
 
         index_ = static_cast<util::selection_type>(a_id);