feat: add FrontendError #5942
feat: add FrontendError #5942
Conversation
frontend/gateway/gateway.go
Outdated
| @@ -63,7 +63,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| keySource = "source" | |||
| KeySource = "source" | |||
There was a problem hiding this comment.
Is this const made public so it can be used downstream? If so, it should first be moved to another package to avoid unnecessary imports similar to https://github.com/moby/buildkit/blob/master/exporter/exptypes/keys.go
There was a problem hiding this comment.
This seems to be all internal impports so not a big issue. If you want can move it to frontend pkg (or errdefs) that I think are already imported.
There was a problem hiding this comment.
I don't mind duplicating the key if you guys think that's preferable.
There was a problem hiding this comment.
I've moved it to frontend, PTAL
frontend/gateway/gateway.go
Outdated
| @@ -63,7 +63,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| keySource = "source" | |||
| KeySource = "source" | |||
There was a problem hiding this comment.
This seems to be all internal impports so not a big issue. If you want can move it to frontend pkg (or errdefs) that I think are already imported.
Marks errors coming from the frontend as such, indicating the frontend name and the source (which identifies the frontend container when using the gateway frontend) Signed-off-by: Alberto Garcia Hierro <damaso.hierro@docker.com>
fiam
force-pushed
the
alberto/frontend-error
branch
from
8e75be2 to
c0205ad
Compare
Marks errors coming from the frontend as such, indicating the frontend
name and the source (which identifies the frontend container when using
the gateway frontend)
Signed-off-by: Alberto Garcia Hierro damaso.hierro@docker.com