-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render Audio Player if Tool Result resource mime type is audio. #99
base: main
Are you sure you want to change the base?
Render Audio Player if Tool Result resource mime type is audio. #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just one small suggestion.
068d213
to
66b1b73
Compare
Hey @evalstate, apologies for the delay here. After some consideration, we'd like to avoid having the inspector showcase any features that aren't in the official spec. So this particular PR will need to wait until the spec discussion you started gets to a resolution. |
Hi Ashwin - This PR renders the audio component if the mime type of the Resource is audio (so in-spec). It's very convenient for testing. The deleted commit handled the change to the Schema - and was accidentally committed to the branch. Ideally changes to the spec could be coordinated with updates to SDK and Inspector for testing. I fat-fingered this one - hence the delete of that commit . Best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thank you for this (sorry taking a long time to get to this!)
I don't have state on the previous iterations, but the diff looks good to me as is
The relevant code has been removed, so the requested changes are no longer relevant
I think you just need to just run |
…e/inspector into feature/audio-rendering
Checking formatting... [warn] client/src/components/ToolsTab.tsx [warn] Code style issues found in the above file. Run Prettier with --write to fix. inspector on feature/audio-rendering [$⇡] is 📦 v0.3.0 via v22.11.0 ❯ npx prettier --write client/src/components/ToolsTab.tsx client/src/components/ToolsTab.tsx 109ms
Done! |
Show the browser audio player if resource mime type is audio.
Motivation and Context
Makes testing audio tool results integration simpler.
How Has This Been Tested?
This has been tested with an MCP Server calling Parler/TTS.
Breaking Changes
No - but the Client Reference Implementation (Claude Desktop does not support Audio content).
Types of changes
Checklist