-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client sampling #132
base: main
Are you sure you want to change the base?
Add client sampling #132
Conversation
seems like the |
I like the concept here. Do you mind pushing this over the finish line? Cleanup, Documentation and Tests? |
Glad you feel that this is the correct way to go about implementing this, if there are no desired changes I am happy to start pushing forwards with docs/testing. |
I've confirmed the functionality is working on my end. However, the testing is blocked by the issue with the sampling test tool in the everything server. Once that's fixed, I can add proper unit tests. Let me know if there are other changes needed in the meantime. |
This adds a sampling request handler parameter to the
ClientSession
Class.Motivation and Context
This will allow for receiving sampling requests inside of python clients.
How Has This Been Tested?
This still needs extensive testing, but for now I have been testing using this example repo https://github.com/SecretiveShell/MCP-python-client-sampling-demo
Breaking Changes
None
Types of changes
Checklist
Additional context
Currently this PR is failing, the example tests work but the response from the everything server isThis is now resolvedresp.content[0].text='LLM sampling result: [object Object]'
I am opening this as a draft PR for the opportunity to get feedback and iterate on the implementation.