Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayExecutor]Check unsupported op before processing #609

Closed
wants to merge 1 commit into from

Conversation

liuyuhanalex
Copy link
Contributor

hi~ 顺便还有个小问题请教, ray_executor, op_fusion的type选择probe的时候会报错
TypeError: object of type 'RayDataset' has no len()
我感觉是不是probe_small_batch 里面的take_batch没有考虑RayDataset呢? 还是我配置的问题呢?

@pan-x-c
Copy link
Collaborator

pan-x-c commented Mar 5, 2025

目前 op_fusion 主要面向单机模式,ray dataset 操作内部会自动执行类似 fusion 的操作,不需要外部指定

@liuyuhanalex
Copy link
Contributor Author

目前 op_fusion 主要面向单机模式,ray dataset 操作内部会自动执行类似 fusion 的

了解了! 感谢! 是不是ray_executor里面op_fusion部分代码也是应该删掉的呢

@pan-x-c
Copy link
Collaborator

pan-x-c commented Mar 5, 2025

暂时可以先不管这部分,我们正在对 dataset 和 executor 进行大范围重构,后续会统一修改

@liuyuhanalex
Copy link
Contributor Author

暂时可以先不管这部分,我们正在对 dataset 和 executor 进行大范围重构,后续会统一修改

好的, 了解了! 感谢 ૮₍。••。₎ა

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants