forked from szandany/Liquibase_Snowflake_Example
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lbjenn patch 1 #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH workflow failed for this issue https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ and upload-artifact has a v4 now so can't use v3
updated log level for trouble shooting
… lbjenn-patch-1 changes in remote are for GHA workflows only and local change is only for QC config file version
changed the actions/upload-artifact calls for DEV & TEST to use v4
changed docker pull to get latest LB version
updated checkout calls to actions/checkout@v4
Updated snapshot files to be 4.28.0 and docker to use 4.28.0
Removed grep command to show diff as we now have drift report Added parameters to rollback command to product a rollback report
changed log level
added in reports enabled and env name for report file
Changed the log artifact name for the zip file to include the env label so update-artifacts@v4 does not fail saying there is an artifact with this name in this run
UPdated the actions/checkout github function to v4
Updated actions/checkout to v4
Added artifact upload step in each env to capture the rollback report
Updated actions/checkout to v4
Added rollback stmt back in
molivasdat
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made several changes so that workflows would run successfully and gather report artifacts. run_changes and run_targeted_rollback are using Liquibase 4.28.0 explicitly instead of latest.