Skip to content

Commit

Permalink
Remove use of oldest-supported-numpy when building wheels.
Browse files Browse the repository at this point in the history
* the package is deprecated in light of upcoming numpy 2.0
  • Loading branch information
molpopgen committed Jan 23, 2024
1 parent 8c3cdae commit 2c2ae2e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ jobs:
# Upgrade pip to get bdist_wheel
pip install --upgrade pip
pip install setuptools wheel build
# Instead of letting setup.py install a newer numpy we install it here
# using the oldest supported version for ABI compatibility
pip install oldest-supported-numpy
- name: Build Wheel
run: |
python -m build --wheel
Expand Down
2 changes: 1 addition & 1 deletion deployment/linux_wheels/wheel_workflow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ git config --global --add safe.directory /project

$(which $PYTHON) -m venv venv
source venv/bin/activate
python -m pip install --upgrade pip setuptools build oldest-supported-numpy
python -m pip install --upgrade pip setuptools build
python -m build .
deactivate
rm -rf build venv
Expand Down

0 comments on commit 2c2ae2e

Please sign in to comment.