Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export to tskit when demographic models end in the past. #1255

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix export to tskit when demographic models end in the past. #1255

merged 1 commit into from
Jan 19, 2024

Conversation

molpopgen
Copy link
Owner

@molpopgen molpopgen commented Dec 14, 2023 •
edited
Loading

See #1253

@molpopgen molpopgen mentioned this pull request Dec 14, 2023
Closed
@molpopgen molpopgen force-pushed the models_with_end_times_in_past branch from 8d9dbc5 to 3bf9f26 Compare December 22, 2023 16:35
@molpopgen molpopgen force-pushed the models_with_end_times_in_past branch 2 times, most recently from 0b37455 to 258e9b5 Compare January 18, 2024 23:31
@molpopgen
Fix behavior of building DiploidPopulation from a tree
9a2f35c 
sequence that has alive node times all > 0.0.

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
@molpopgen molpopgen force-pushed the models_with_end_times_in_past branch from 6a7add2 to 9a2f35c Compare January 18, 2024 23:55
@molpopgen molpopgen enabled auto-merge (squash) January 18, 2024 23:56
@molpopgen molpopgen disabled auto-merge January 19, 2024 00:15
@molpopgen molpopgen merged commit 5983801 into dev Jan 19, 2024
41 checks passed
@molpopgen molpopgen deleted the models_with_end_times_in_past branch January 19, 2024 00:28
molpopgen added a commit that referenced this pull request Jan 19, 2024
@molpopgen
Fix exporting to tskit.TreeSeuqence when demographic models
ae904d0 
end at times > 0. (#1255)

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
molpopgen added a commit that referenced this pull request Jan 19, 2024
@molpopgen
Fix exporting to tskit.TreeSequence when demographic models
d2dc10a 
end at times > 0. (#1255)

* manual: remove documentation on allowing > 1 ModelParams exported to
tskit.
* remove test of multiple modelparam export

See #1257 and #1256

Fixes #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@molpopgen