test: Reimplement the Unit Test "requires" #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamsha
commented
Apr 5, 2024
Comment on lines
+1
to
+2
| /* eslint-disable import/no-dynamic-require */ | ||
| /* eslint-disable n/global-require */ |
There was a problem hiding this comment.
This test requires dynamic require, so disable the rules for this.
There was a problem hiding this comment.
Delete this file as it's no longer used.
The reimplemented Unit Test revealed that it was unnecessary.
There was a problem hiding this comment.
Delete this file as it's no longer used.
The reimplemented Unit Test revealed that it was unnecessary.
wakamsha
commented
Apr 5, 2024
Comment on lines
-12
to
-14
| dirs.forEach((dir) => { | ||
| files = readdirRecursively(dir, files); | ||
| }); |
There was a problem hiding this comment.
the processing on L10 is canceled here.
wakamsha
added a commit
that referenced
this pull request
Apr 18, 2024
* implement `requires` test * lint test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing Unit Test
/tests/requires.test.jswasn't working properly, so I reimplemented it.This test collects the paths of JavaScript files under the specified directory and checks whether they can be loaded correctly (they can be worked
require).However, when I ran the test, I found that it wasn't being collected at all. This was caused by an incorrect implementation of the recursive function, and this was corrected to make it work correctly.
Other
Introduced
eslint-config-prettierto properly format test code with ESLint and Prettier.References